From: "H. Peter Anvin" <hpa@zytor.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
venkatesh.pallipadi@intel.com, akpm@linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap
Date: Tue, 15 Jan 2008 07:52:00 -0500 [thread overview]
Message-ID: <478CAC70.80309@zytor.com> (raw)
In-Reply-To: <1200390535.3505.62.camel@caritas-dev.intel.com>
Huang, Ying wrote:
>
> After checking the early_ioremap() implementation in
> arch/x86/kernel/setup_32.c, I found that it is a duplication of
> bt_ioremap() implementation in arch/x86/mm/ioremap_32.c. Both
> implementations use set_fixmap(), so they can be used only after
> paging_init().
>
> The early_ioremap implementation provided in this patchset works as
> follow:
>
> - Enhances bt_ioremap, make it usable before paging_init() via a
> dedicated PTE page.
> - Rename bt_ioremap to early_ioremap
>
> So I think maybe we should replace the early_ioremap() implementation in
> PAT series with that of this series.
>
I did a quick scan over the patchset (not quite awake yet, so I may very
well have missed something), but it looks like EFI (again!) is the only
user of ioremapping before paging_init(). This makes me wonder if that
code can't be restructured so that isn't necessary.
-hpa
next prev parent reply other threads:[~2008-01-15 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 5:45 [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap Huang, Ying
2008-01-15 8:44 ` Ingo Molnar
2008-01-15 9:48 ` Huang, Ying
2008-01-15 12:52 ` H. Peter Anvin [this message]
2008-01-15 13:39 ` Ingo Molnar
2008-01-15 13:38 ` H. Peter Anvin
2008-01-15 13:36 ` Ingo Molnar
2008-01-16 2:51 ` [PATCH -mm 0/3] i386 boot: replace boot_ioremap with enhancedbt_ioremap Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478CAC70.80309@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox