public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: move warning message of polling idle and HT	enabled
Date: Tue, 15 Jan 2008 09:53:30 -0800	[thread overview]
Message-ID: <478CF31A.8040305@ct.jp.nec.com> (raw)
In-Reply-To: <20080115132607.GE7025@elte.hu>

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> 
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> Subject: [PATCH] x86: move warning message of polling idle and HT enabled
>>
>> This warning at idle_setup() is never shown because smp_num_sibling hasn't
>> been updated at this point yet.
>>
>> Move this polling idle and HT enabled warning message to 
>> select_idle_routine(). I also implement this warning on 64-bit kernel 
>> and make select_idle_routine() call after detect_ht() call.
> 
> looks good to me, but could you please split this up into two patches 
> instead - one that just moves/adds the printks, the other one that moves 
> the select_idle_routine() call? (Moving init calls around is notoriously 
> error-prone, so we want as small of a bisection target as possible.) 

Sure, I'll repost take3 soon.

Thanks,
Hiroshi Shimamoto


  reply	other threads:[~2008-01-15 17:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 19:04 [PATCH] x86_32: remove warning message not used Hiroshi Shimamoto
2008-01-14 19:09 ` Ingo Molnar
2008-01-14 19:19   ` Hiroshi Shimamoto
2008-01-15  2:03   ` [PATCH] x86: move warning message of polling idle and HT enabled Hiroshi Shimamoto
2008-01-15 13:26     ` Ingo Molnar
2008-01-15 17:53       ` Hiroshi Shimamoto [this message]
2008-01-15 18:56       ` [PATCH 0/2] x86: move warning message of polling idle and HT enabled, take 3 Hiroshi Shimamoto
2008-01-15 18:59         ` [PATCH 1/2] x86: move warning message of polling idle and HT enabled Hiroshi Shimamoto
2008-01-18 12:56           ` Ingo Molnar
2008-01-15 19:01         ` [PATCH 2/2] x86_64: move select_idle_routine() call after detect_ht() Hiroshi Shimamoto
2008-01-18 12:56           ` Ingo Molnar
2008-01-18  2:52   ` x86: kdump failure Hiroshi Shimamoto
2008-01-18  9:02     ` Ingo Molnar
2008-01-18  9:29       ` Subrata Modak
2008-01-19  0:01       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478CF31A.8040305@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox