From: "H. Peter Anvin" <hpa@zytor.com>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c
Date: Tue, 15 Jan 2008 22:22:23 -0500 [thread overview]
Message-ID: <478D786F.2040505@zytor.com> (raw)
In-Reply-To: <20080116031149.GA14210@phobos.i.cabal.ca>
Kyle McMartin wrote:
> On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote:
>> +#ifdef CONFIG_X86_F00F_BUG
>> +void do_invalid_op(struct pt_regs *, unsigned long);
>> +#endif
>> +
>> +static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
>> +{
>> +#ifdef CONFIG_X86_F00F_BUG
>> + unsigned long nr;
>
> You can just put the prototype inside the function, you know...
You can also make the prototype unconditional, even if the function
doesn't necessarily exist.
-hpa
next prev parent reply other threads:[~2008-01-16 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 2:48 [PATCH] x86: add is_f00f_bug helper to fault_32|64.c Harvey Harrison
2008-01-16 3:11 ` Kyle McMartin
2008-01-16 3:22 ` H. Peter Anvin [this message]
2008-01-16 3:42 ` [PATCHv2] " Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478D786F.2040505@zytor.com \
--to=hpa@zytor.com \
--cc=harvey.harrison@gmail.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox