From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757188AbYAQUwj (ORCPT ); Thu, 17 Jan 2008 15:52:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752925AbYAQUwa (ORCPT ); Thu, 17 Jan 2008 15:52:30 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:54479 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbYAQUw3 (ORCPT ); Thu, 17 Jan 2008 15:52:29 -0500 Message-ID: <478FBFDB.4000600@oracle.com> Date: Thu, 17 Jan 2008 12:51:39 -0800 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Len Brown CC: Zhang Rui , linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sujith.thomas@intel.com Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver References: <1200556278.2935.118.camel@acpi-sony.sh.intel.com> <20080117092030.a9dfe528.randy.dunlap@oracle.com> <200801171451.18613.lenb@kernel.org> In-Reply-To: <200801171451.18613.lenb@kernel.org> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Len Brown wrote: >>> +static int >>> +memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev, >>> + unsigned long *max_state) >> Don't put 'static int' (return type etc.) on a line by itself. >> That format is not wanted in Linux. (many places here) > > if checkpatch.pl and Lindent are happey (which they are not, totally) > then I'm satisifed witht he Linux style of the code. > > Randy, if you feel strongly about this this style nit, > then change Lindent to implement it -- nagging > developers about trivia is a waste of everybody's time. > > thanks, > -Len http://marc.info/?l=linux-kernel&m=105451996829576&w=2 Thanks. -- ~Randy