Re: [patch 0/4] x86: PAT followup - Incremental changes and bug fixes

Ingo Molnar
2008-01-17T20:36:49Z

* Andreas Herrmann3 <andreas.herrmann3@amd.com> wrote:

> For the failed devices I get:
>
> sata_sil 0000:00:12.0: version 2.3
> ACPI: PCI Interrupt 0000:00:12.0[A] -> GSI 22 (level, low) -> IRQ 22
> ioremap_nocache: addr c0403000, size 200
> swapper:1 conflicting cache attribute c0403000-c0404000 uncached<->default
> ACPI: PCI interrupt for device 0000:00:12.0 disabled

hm, is the problem that the two devices share the same physical page,
and thus get an overlapping area?

as an intermediate fix, how about following the attribute of the already
existing mapping, instead of rejecting the ioremap due to the conflict?
I.e. something like below?

Ingo

---
arch/x86/mm/pat.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/mm/pat.c
===================================================================
--- linux-x86.q.orig/arch/x86/mm/pat.c
+++ linux-x86.q/arch/x86/mm/pat.c
@@ -174,7 +174,12 @@ int reserve_mattr(u64 start, u64 end, un
current->comm, current->pid,
start, end,
cattr_name(attr), cattr_name(ml->attr));
- err = -EBUSY;
+ /*
+ * Force the already existing attribute:
+ */
+ ma->attr = ml->attr;
+ if (*fattr)
+ *fatt = ml->attr;
break;
}
} else if (ml->start >= end) {