Re: [patch 0/4] x86: PAT followup - Incremental changes and bug fixes

Venki Pallipadi
2008-01-17T23:04:42Z

On Thu, Jan 17, 2008 at 11:52:43PM +0100, Andreas Herrmann3 wrote:
> On Thu, Jan 17, 2008 at 11:15:05PM +0100, Ingo Molnar wrote:
> >
> > * Andreas Herrmann3 <andreas.herrmann3@AMD.COM> wrote:
> >
> > > On Thu, Jan 17, 2008 at 10:42:09PM +0100, Ingo Molnar wrote:
> > > >
> > > > * Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> > > >
> > > > > On Thu, Jan 17, 2008 at 10:13:08PM +0100, Ingo Molnar wrote:
> > > > > > but in general we must be robust enough in this case and just degrade
> > > > > > any overlapping page to UC (and emit a warning perhaps) - instead of
> > > > > > failing the ioremap and thus failing the driver (and the bootup).
> > > > >
> > > > > But then, this will cause an attribute conflicit. Old one was
> > > > > specifying WB in PAT (ioremap with noflags) and the new ioremap
> > > > > specifies UC.
> > > >
> > > > we could fix up all aliases of that page as well and degrade them to UC?
> > >
> > > Yes, we must fix all aliases or reject the conflicting mapping. But
> > > fixing all aliases might not be that easy. (I've just seen a panic
> > > when using your patch ;-(
> >
> > yes, indeed my patch is bad if you have PAT enabled: conflicting cache
> > attributes might be present. I'll go with your patch for now.
>
> I think the best is to just reject conflicting mappings. (Because now
> I am too tired to think about a safe way how to change the aliases to the
> most restrictive memory type. ;-)
>
> But then of course such boot-time problems like I've seen on my test
> machines should be avoided somehow.
>
>

Below is another potential fix for the problem here. Going through ACPI
ioremap usages, we found at one place the mapping is cached for possible
optimization reason and not unmapped later. Patch below always unmaps
ioremap at this place in ACPICA.

Thanks,
Venki

Index: linux-2.6.git/drivers/acpi/executer/exregion.c
===================================================================
--- linux-2.6.git.orig/drivers/acpi/executer/exregion.c 2008-01-17 03:18:39.000000000 -0800
+++ linux-2.6.git/drivers/acpi/executer/exregion.c 2008-01-17 07:34:33.000000000 -0800
@@ -48,6 +48,8 @@
#define _COMPONENT ACPI_EXECUTER
ACPI_MODULE_NAME("exregion")

+static int ioremap_cache;
+
/*******************************************************************************
*
* FUNCTION: acpi_ex_system_memory_space_handler
@@ -249,6 +251,13 @@
break;
}

+ if (!ioremap_cache) {
+ acpi_os_unmap_memory(mem_info->mapped_logical_address,
+ window_size);
+ mem_info->mapped_logical_address = 0;
+ mem_info->mapped_physical_address = 0;
+ mem_info->mapped_length = 0;
+ }
return_ACPI_STATUS(status);
}