From: Joe Peterson <joe@skyrush.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] (*revised*) Fix IXANY and restart after signal (e.g. ctrl-C) in n_tty line discipline
Date: Thu, 17 Jan 2008 17:38:10 -0700 [thread overview]
Message-ID: <478FF4F2.2050004@skyrush.com> (raw)
In-Reply-To: <20080117161156.92737c80.akpm@linux-foundation.org>
Andrew Morton wrote:
> What were the "couple of issues"?
They are the same 2 issues described in the original version of the
patch and included in the text of this one too (i.e. the text at the
start of this latest patch version is the same as before).
>> This patch should *replace* the old version of the patch.
>
> I don't like replacements a lot. It forces one to re-review the whole
> thing from scratch. Which is why I almost always turn the replacement
> into an incremental patch, as below.
I see your point. Cool, thanks for making the update patch, and I'll
submit them like that in the future.
-Thanks, Joe
prev parent reply other threads:[~2008-01-18 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 14:19 [PATCH] Fix IXANY and restart after signal (e.g. ctrl-C) in n_tty line discipline Joe Peterson
2008-01-17 23:44 ` [PATCH] (*revised*) " Joe Peterson
2008-01-18 0:11 ` Andrew Morton
2008-01-18 0:38 ` Joe Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478FF4F2.2050004@skyrush.com \
--to=joe@skyrush.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox