Re: [PATCH 1/2] x86: unify pt_regs accessors ptrace.h

["H. Peter Anvin" <hpa@zytor.com>]

Harvey Harrison wrote:
> On Thu, 2008-01-17 at 20:56 -0500, H. Peter Anvin wrote:
>> Harvey Harrison wrote:
>>> Unify the definiton of:
>>> v8086_mode
>>> user_mode
>>> user_mode_vm
>>> stack_pointer
>>> instruction_pointer
>>> frame_pointer
>>>
>>> in ptrace.h to make it clear where the differences are between
>>> 32 and 64 bit.  Changes macros to static inlines as well.
>>>
>> Can you put a comment on stack_pointer() that it applies to a 
>> kernel-mode pt_regs only?
> 
> How about a follow-on patch that picks a better name and adds the
> comment?  I'd like to leave this as a movement-only patch.  Once we
> decide on a name I'll do the rename/comment.  It seems like there are
> very few users currently (oprofile/backtrace.c only?).
> 
> Then I'll also change the kprobes code to use this instead of their
> stack_addr helper.
> 

IMO, go ahead and add a comment, but yes, renaming should be a separate 
patch.

	-hpa