From: "Jan Beulich" <jbeulich@novell.com>
To: "Greg KH" <greg@kroah.com>
Cc: <davem@davemloft.net>, <schwidefsky@de.ibm.com>, <mingo@elte.hu>,
<tony.luck@intel.com>, <paulus@samba.org>, <gregkh@suse.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] constify struct attribute_group uses (against -mm)
Date: Wed, 23 Jan 2008 09:32:40 +0000 [thread overview]
Message-ID: <479717C8.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20080122221547.GA32588@kroah.com>
>>> Greg KH <greg@kroah.com> 22.01.08 23:15 >>>
>On Tue, Jan 22, 2008 at 01:31:21PM +0000, Jan Beulich wrote:
>> .. as all consumers of it don't require it to be modifiable.
>>
>> Unfortunately, due to the two-level constifications, this required
>> touching quite many files, not all of which I am able to test - please
>> bare with eventual mistakes or oversights.
>>
>> The patch doesn't change all instances where 'const' could have been
>> added as a result of the base structure changes, only where either the
>> change has a real effect (the module loader doesn't enforce read-only
>> section attributes at present, so only built-in files matter) or where
>> compiler warnings would result otherwise.
>
>Which -mm is this against? Seems to not apply here :(
2.6.24-rc8-mm1 - I'm keeping the name in the diff headers so that one
can easily identify the baseline a patch is against, as in
--- 2.6.24-rc8-mm1-const.orig/arch/ia64/kernel/err_inject.c
+++ 2.6.24-rc8-mm1-const/arch/ia64/kernel/err_inject.c
Jan
prev parent reply other threads:[~2008-01-23 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 13:31 [PATCH 1/3] constify struct attribute_group uses (against -mm) Jan Beulich
2008-01-22 22:15 ` Greg KH
2008-01-23 9:32 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479717C8.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox