From: Mike Travis <travis@sgi.com>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Ingo Molnar <mingo@elte.hu>, Christoph Lameter <clameter@sgi.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr
Date: Wed, 23 Jan 2008 06:37:18 -0800 [thread overview]
Message-ID: <4797511E.9020704@sgi.com> (raw)
In-Reply-To: <47974C53.2060202@sgi.com>
Mike Travis wrote:
> Yinghai Lu wrote:
>> [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr
>>
>> Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
>>
>> diff --git a/arch/x86/kernel/setup_64.c b/arch/x86/kernel/setup_64.c
>> index 2643a8f..b587166 100644
>> --- a/arch/x86/kernel/setup_64.c
>> +++ b/arch/x86/kernel/setup_64.c
>> @@ -349,7 +349,6 @@ void __init setup_arch(char **cmdline_p)
>> #ifdef CONFIG_NUMA
>> x86_cpu_to_node_map_early_ptr = (void *)&x86_cpu_to_node_map_init;
>> #endif
>> - x86_bios_cpu_apicid_early_ptr = (void *)&x86_bios_cpu_apicid_init;
>> #endif
>>
>> #ifdef CONFIG_ACPI
>
>
> Thanks Yinghai!
>
> I wonder how this got past my testing (I do build and test !SMP and !NUMA
> versions.) I'll check into this.
Hmm, never mind. Coffee has cleared up my confusion...
>
> Regards,
> Mike
prev parent reply other threads:[~2008-01-23 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 8:56 [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr Yinghai Lu
2008-01-23 9:27 ` [PATCH] x86_64: should use array directly for early_ptr Yinghai Lu
2008-01-23 14:18 ` Mike Travis
2008-01-23 14:16 ` [PATCH] x86_64: remove duplicated line about x86_bios_cpu_apicid_early_ptr Mike Travis
2008-01-23 14:37 ` Mike Travis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4797511E.9020704@sgi.com \
--to=travis@sgi.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox