Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE

Harvey Harrison
2008-01-22T21:35:22Z

On Tue, 2008-01-22 at 22:04 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > nx_enabled can only be set to non-zero when CONFIG_X86_PAE is set.
> > The only use not currently inside a CONFIG_X86_PAE block is the
> > definition, the declaration and a conditional unlikely test in
> > fault_32.c (is_prefetch).
> >
> > When !CONFIG_X86_PAE, is_prefetch always returns 0 immediately as
> > nx_enabled is always 0.
> >
> > When CONFIG_X86_PAE, the test is preserved, but the test against the
> > cpu model and stepping is deleted, this may not be correct.
>
> thanks, applied.

Hmmm, the extern nx_enabled in page_32.h is already within an
ifndef __ASSEMBLY__ block, so I'm not sure how wakeup_32.S could
be using it. Thoughts?

Harvey