Re: [PATCH] x86: Construct 32 bit boot time page tables in native format.

H. Peter Anvin
2008-01-25T00:20:25Z

Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> Yeah, I'm aware of this particular piece of Xen braindamage, and
>> although I had some very unkind words to say about it, it mirrors what
>> we have to do for the !PAE case anyway, so it can be sort of glossed
>> over.
>
> Sort of. If Xen weren't an issue, then both cases are a matter of
> copying a set of entries from one place in the pgd to another.
>

No, if Xen wasn't an issue there wouldn't be anything to do for the PAE
case at all (since the PGD is trivial.)

Copying PMDs is more or less an analogous case of the !PAE case, once
the allocation is already done. The allocation should be trivial
though, since this would be a one-time thing.

> It would be easy enough to add some code on xen side to look for pmd
> aliases when using/pinning a pagetable, and allocate'n'copy a new pmd
> page as needed. That way the core code can ignore the issue.

As much as I'd rather see Xen fixing this than having it continue to
impact the kernel, I presume it will take some time to flush the broken
hypervisors out?

-hpa