Re: [PATCH] x86: make nx_enabled conditional on CONFIG_X86_PAE

Harvey Harrison
2008-01-23T11:21:31Z

On Wed, 2008-01-23 at 09:46 +0100, Andi Kleen wrote:
> Harvey Harrison <harvey.harrison@gmail.com> writes:
>
> > nx_enabled can only be set to non-zero when CONFIG_X86_PAE is
> > set. The only use not currently inside a CONFIG_X86_PAE block
> > is the definition, the declaration and a conditional unlikely
> > test in fault_32.c (is_prefetch).
>
> The variable is pretty useless anyways; it can be probably
> replaced with (__supported_pte_mask & _PAGE_NX). Just make
> sure that the disable option still works, but that should
> be possible with some care.
>
> So if you feel the need to clean up things here convert it
> to using that. That will automatically be optimized away
> on !PAE too because _PAGE_NX is 0 there.
>

Noted, will do.

Harvey