From: Ben Nizette <bn@niasdigital.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32
Date: Thu, 24 Jan 2008 21:38:56 +1100 [thread overview]
Message-ID: <47986AC0.8000806@niasdigital.com> (raw)
In-Reply-To: <20080124112911.0b1592f4@dhcp-252-066.norway.atmel.com>
Haavard Skinnemoen wrote:
> On Wed, 23 Jan 2008 22:53:54 +1100
> Ben Nizette <bn@niasdigital.com> wrote:
>
>> /*
>> + * We just keep an empty definition of this around (a-la the asm-generic
>> + * implementation) to keep /dev/mem happy
>> + */
>> +#define unxlate_dev_mem_ptr(p, a) {}
>
> Thanks, but this should be either
>
> #define unxlate_dev_mem_ptr(p, a) do { } while (0)
>
> or
>
> static inline void unxlate_dev_mem_ptr(unsigned long phys, void *addr)
> {
> }
>
> I prefer the latter.
Yeah I don't know what came over me; Mia culpa :-)
I prefer the latter too, though I think I was striving for consistency with the xlate_dev_mem_ptr #define.
--Ben
next prev parent reply other threads:[~2008-01-24 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 11:53 [PATCH -mm] define empty unxlate_dev_mem_ptr on AVR32 Ben Nizette
2008-01-24 10:29 ` Haavard Skinnemoen
2008-01-24 10:38 ` Ben Nizette [this message]
2008-01-27 6:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47986AC0.8000806@niasdigital.com \
--to=bn@niasdigital.com \
--cc=akpm@linux-foundation.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox