From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756059AbYAXQFo (ORCPT ); Thu, 24 Jan 2008 11:05:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755870AbYAXQFd (ORCPT ); Thu, 24 Jan 2008 11:05:33 -0500 Received: from mx1.redhat.com ([66.187.233.31]:44484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755850AbYAXQFc (ORCPT ); Thu, 24 Jan 2008 11:05:32 -0500 Message-ID: <4798B747.1040408@redhat.com> Date: Thu, 24 Jan 2008 11:05:27 -0500 From: Jarod Wilson Organization: Red Hat, Inc. User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Stefan Richter CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Kristian_H=F8gsberg?= , Nick Piggin Subject: Re: [PATCH 2/4] firewire: fw-cdev: use device generation, not card generation References: <200711011453.35268.nickpiggin@yahoo.com.au> <4729A1BF.8010800@s5r6.in-berlin.de> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Richter wrote: > We have to use the fw_device.generation here, not the fw_card.generation, > because the generation must never be newer than the node ID when we emit > a transaction. This cannot be guaranteed with fw_card.generation. > > Signed-off-by: Stefan Richter Verified in concert with parts 1 and 3 as well as with 1, 3 and 4, to fix 'giving up on config rom' issues on multiple system and drive combinations that were previously affected. Signed-off-by: Jarod Wilson -- Jarod Wilson jwilson@redhat.com