public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: Heikki Orsila <shdl@zakalwe.fi>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, tigran@aivazian.fsnet.co.uk
Subject: Re: [PATCH 5/9] bfs: move function prototype to the proper header file
Date: Fri, 25 Jan 2008 02:13:00 +0300	[thread overview]
Message-ID: <47991B7C.6000208@gmail.com> (raw)
In-Reply-To: <20080124225031.GC12172@zakalwe.fi>

Heikki Orsila пишет:
> On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote:
>> diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
>> index 090b96e..ecc74bb 100644
>> --- a/fs/bfs/bfs.h
>> +++ b/fs/bfs/bfs.h
> ...
>> +/* inode.c */
>> +extern void dump_imap(const char *, struct super_block *);
>> +
> 
> Functions should not be externed, remove extern keyword.
> 

Care to explain why?

Following is an explanation why the contrary is probably true:

1) We have lots of precedents in existing code:

dmvo@cipher:~/Projects/misc/linux$ git-grep 'extern void' include | wc -l
5523
dmvo@cipher:~/Projects/misc/linux$

2) Linus' Coding style does not mandate what you requested.

3) The checkpatch.pl did not complain at this particular patch.

Thanks,

Dmitri


  parent reply	other threads:[~2008-01-24 23:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 22:31 [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 1/9] bfs: remove a useless variable Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 2/9] bfs: coding style cleanup in fs/bfs/inode.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 3/9] bfs: coding style cleanup in fs/bfs/bfs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 4/9] bfs: coding style cleanup in fs/bfs/dir.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 5/9] bfs: move function prototype to the proper header file Dmitri Vorobiev
2008-01-24 22:50   ` Heikki Orsila
2008-01-24 23:08     ` Tigran Aivazian
2008-01-24 23:17       ` Tigran Aivazian
2008-01-24 23:13     ` Dmitri Vorobiev [this message]
2008-01-24 23:22       ` Tigran Aivazian
2008-01-24 23:30         ` Dmitri Vorobiev
2008-01-25 10:42         ` Adrian Bunk
2008-01-25 11:12           ` Dmitri Vorobiev
2008-01-24 23:33       ` Heikki Orsila
2008-01-24 23:47         ` Dmitri Vorobiev
2008-01-25  1:55       ` Kyle Moffett
2008-01-24 22:32 ` [PATCH 6/9] bfs: coding style cleanup in fs/bfs/file.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 7/9] bfs: coding style cleanup in include/linux/bfs_fs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 8/9] bfs: remove multiple assignments Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 9/9] bfs: use the proper header file for inclusion Dmitri Vorobiev
2008-01-25 10:25 ` [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47991B7C.6000208@gmail.com \
    --to=dmitri.vorobiev@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shdl@zakalwe.fi \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox