From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: Heikki Orsila <shdl@zakalwe.fi>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, tigran@aivazian.fsnet.co.uk
Subject: Re: [PATCH 5/9] bfs: move function prototype to the proper header file
Date: Fri, 25 Jan 2008 02:47:55 +0300 [thread overview]
Message-ID: <479923AB.5050301@gmail.com> (raw)
In-Reply-To: <20080124233313.GD12172@zakalwe.fi>
Heikki Orsila пишет:
> On Fri, Jan 25, 2008 at 02:13:00AM +0300, Dmitri Vorobiev wrote:
>> Care to explain why?
>
> Because functions are always external objects in C. I just verified that
> from K&R.
>
Yes, I know that :)
The reasons behind me using this keyword were: 1) to keep the code symmetric;
2)-4) as explained elsewhere in this thread.
Anyways, you and Tigran have been convincing enough and the corrected patch
is there.
Thanks,
Dmitri
next prev parent reply other threads:[~2008-01-24 23:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 22:31 [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 1/9] bfs: remove a useless variable Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 2/9] bfs: coding style cleanup in fs/bfs/inode.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 3/9] bfs: coding style cleanup in fs/bfs/bfs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 4/9] bfs: coding style cleanup in fs/bfs/dir.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 5/9] bfs: move function prototype to the proper header file Dmitri Vorobiev
2008-01-24 22:50 ` Heikki Orsila
2008-01-24 23:08 ` Tigran Aivazian
2008-01-24 23:17 ` Tigran Aivazian
2008-01-24 23:13 ` Dmitri Vorobiev
2008-01-24 23:22 ` Tigran Aivazian
2008-01-24 23:30 ` Dmitri Vorobiev
2008-01-25 10:42 ` Adrian Bunk
2008-01-25 11:12 ` Dmitri Vorobiev
2008-01-24 23:33 ` Heikki Orsila
2008-01-24 23:47 ` Dmitri Vorobiev [this message]
2008-01-25 1:55 ` Kyle Moffett
2008-01-24 22:32 ` [PATCH 6/9] bfs: coding style cleanup in fs/bfs/file.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 7/9] bfs: coding style cleanup in include/linux/bfs_fs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 8/9] bfs: remove multiple assignments Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 9/9] bfs: use the proper header file for inclusion Dmitri Vorobiev
2008-01-25 10:25 ` [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479923AB.5050301@gmail.com \
--to=dmitri.vorobiev@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shdl@zakalwe.fi \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox