From: "Heiko Stübner" <heiko@sntech.de>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: dianders@chromium.org, kishon@ti.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-usb@vger.kernel.org, kever.yang@rock-chips.com,
huangtao@rock-chips.com, william.wu@rock-chips.com,
frank.wang@rock-chips.com.org
Subject: Re: [PATCH 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY
Date: Thu, 02 Jun 2016 00:17:46 +0200 [thread overview]
Message-ID: <4799985.esYaUoo40j@diego> (raw)
In-Reply-To: <574E9845.30501@rock-chips.com>
Hi Frank,
Am Mittwoch, 1. Juni 2016, 16:09:41 schrieb Frank Wang:
> > You might want to add the bvalid and id interrupts for the otg phys as
> > well
> > already - would make handling legacy devicetree files easier. [= if they
> > get specified later, the driver would always need to also handle
> > devicetrees where they aren't specified].
>
> Hmmm! you mean that I can specify these properties into documentation,
> even if the driver have not handled (implemented) them in current?
The devicetree bindings are supposed to be a generic hardware-description.
And a driver then simply implements that binding. So if the interrupt is part
of the hardware it can be part of the binding, independent of the driver.
I guess it really comes down to, will you need those interrupts later in the
driver, then they should definitly be specified now, as later on you cannot
require them anymore and always need to also support devicetrees not having
them.
Heiko
next prev parent reply other threads:[~2016-06-01 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 6:40 [PATCH 0/2] Add a new Rockchip usb2 phy driver Frank Wang
2016-05-31 6:40 ` [PATCH 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY Frank Wang
2016-05-31 9:02 ` Heiko Stübner
2016-06-01 8:09 ` Frank Wang
2016-06-01 22:17 ` Heiko Stübner [this message]
2016-06-02 2:53 ` Frank Wang
2016-06-01 22:02 ` Rob Herring
2016-05-31 6:40 ` [PATCH 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy Frank Wang
2016-06-01 23:46 ` Heiko Stübner
2016-06-02 3:19 ` Frank Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4799985.esYaUoo40j@diego \
--to=heiko@sntech.de \
--cc=dianders@chromium.org \
--cc=frank.wang@rock-chips.com \
--cc=frank.wang@rock-chips.com.org \
--cc=galak@codeaurora.org \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kever.yang@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox