From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <Yinghai.Lu@Sun.COM>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: trim ram need to check if mtrr is there v3
Date: Fri, 25 Jan 2008 10:59:09 -0800 [thread overview]
Message-ID: <479A317D.6020202@goop.org> (raw)
In-Reply-To: <20080125110935.GA20026@elte.hu>
Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>
>> [PATCH] x86: trim ram need to check if mtrr is there v3
>>
>
>
>>> H. Peter Anvin wrote:
>>> Looks like the code doesn't check that the CPU *has* MTRRs...
>>>
>> so more strict check if mtrr is there really.
>> bail out if mtrr all blank when qemu cpu model is used
>>
>> and check if is AMD as early
>> also remove 4G less check, according to hpa.
>>
>
> thanks, applied. Shouldnt we put in an exception for when there is MTRR
> support, but they dont cover anything. Still emit a warning - but
> booting up real slow is still better than losing all of RAM and crashing
> ...
>
> i also updated the messages, they now go like this:
>
> WARNING: strange, CPU MTRRs all blank?
>
> and:
>
> WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 45MB of RAM.
>
Though I don't see this form of message; have you pushed your changes
out to the public x86.git#mm tree?
J
next prev parent reply other threads:[~2008-01-25 18:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 1:44 x86.git: mtrr trimming removes all memory under kvm Jeremy Fitzhardinge
2008-01-25 1:49 ` H. Peter Anvin
2008-01-25 2:21 ` Yinghai Lu
2008-01-25 2:32 ` Yinghai Lu
2008-01-25 10:52 ` Andi Kleen
2008-01-25 3:47 ` [PATCH] x86: trim ram need to check if mtrr is there v2 Yinghai Lu
2008-01-25 5:44 ` H. Peter Anvin
2008-01-25 7:50 ` Yinghai Lu
2008-01-25 7:43 ` Jeremy Fitzhardinge
2008-01-25 8:13 ` Yinghai Lu
2008-01-25 8:39 ` Yinghai Lu
2008-01-25 11:12 ` Ingo Molnar
2008-01-25 15:47 ` H. Peter Anvin
2008-01-25 8:42 ` [PATCH] x86: trim ram need to check if mtrr is there v3 Yinghai Lu
2008-01-25 11:09 ` Ingo Molnar
2008-01-25 18:55 ` Jeremy Fitzhardinge
2008-01-25 18:59 ` Ingo Molnar
2008-01-25 19:01 ` Jeremy Fitzhardinge
2008-01-25 19:04 ` Ingo Molnar
2008-01-25 19:27 ` Jeremy Fitzhardinge
2008-01-25 19:30 ` Ingo Molnar
2008-01-25 19:32 ` Yinghai Lu
2008-01-25 19:39 ` Jeremy Fitzhardinge
2008-01-25 19:19 ` Yinghai Lu
2008-01-25 19:04 ` Jeremy Fitzhardinge
2008-01-25 18:59 ` Jeremy Fitzhardinge [this message]
2008-01-25 19:02 ` Ingo Molnar
2008-01-25 14:21 ` Ingo Molnar
2008-01-25 14:57 ` Andi Kleen
2008-01-25 15:10 ` Ingo Molnar
2008-01-25 15:57 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479A317D.6020202@goop.org \
--to=jeremy@goop.org \
--cc=Yinghai.Lu@Sun.COM \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox