Re: [kvm-devel] [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs

Avi Kivity
2008-01-27T08:57:18Z

Joerg Roedel wrote:
> Hi,
>
> here is the first release of patches for KVM to support the Nested Paging (NPT)
> feature of AMD QuadCore CPUs for comments and public testing. This feature
> improves the guest performance significantly. I measured an improvement of
> around 17% using kernbench in my first tests.
>
> This patch series is basically tested with Linux guests (32 bit legacy
> paging, 32 bit PAE paging and 64 bit Long Mode). Also tested with Windows Vista
> 32 bit and 64 bit. All these guests ran successfully with these patches. The
> patch series only enables NPT for 64 bit Linux hosts at the moment.
>

Very nice patchset; small, simple, and clean. Apart from the comments I
already posted, I'd like to avoid the term 'hap': I find it
non-descriptive, and it reminds me of another hypervisor. I suggest
'tlp' for two-level paging.

Since it re-uses non-npt real-mode paging, live migration and swapping
will likely work without further changes.

--
error compiling committee.c: too many arguments to function