Re: [PATCH] 2.4: Back-port of pl2303.c from 2.6.23.14

Willy Tarreau
2008-02-02T08:26:43Z

Hi David,

I've CC'd Greg, author of the driver.

On Sat, Jan 26, 2008 at 11:20:38AM +1030, David Newall wrote:
> I experienced major major data loss on a PL-2303 USB-serial converter
> under 2.4.36, which I remedied by back-porting the pl2303.c from the
> latest 2.6 kernel tree.

I'm OK to merge your work in 2.4.36.1 if it fixes bugs for you. I would have
hoped a little more feedback from other users, but let's face it, people
using USB are most often on desktops running 2.6.

I've noticed your other mail about the buffer overflow (which does not
sound like an overflow as we call it in security terms, so it's not
critical). It would be better to merge your work with the fix in it,
but I'll wait for the fix to be in 2.6 first (so that people upgrading
from 2.4 to 2.6 never experience a regression).

If this buffer overflow was not present in 2.4 driver but only in 2.6
(and in the backport), I'd rather wait in order not to break behaviour
for current users of the driver. If both have the same bug, and if Greg
is OK, then let's merge your work as a first evolution before a common
fix.

Based on the above conditions, I'd like you to tell Greg and I if you
consider it worth to merge this backport in 2.4 now. From my point of
view, your work looks OK but I want your feedback as a user (and not
as the backporter), then Greg's approval.

Thanks,
Willy