From: Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging
Date: Sat, 26 Jan 2008 20:38:35 +0200 [thread overview]
Message-ID: <479B7E2B.9080702@qumranet.com> (raw)
In-Reply-To: <20080125221029.GA23111@amd.com>
Joerg Roedel wrote:
>>> +static char *npt = "on";
>>> +
>>> +module_param(npt, charp, S_IRUGO);
>>>
>>>
>> This would probably be better as an integer. Then we don't have to do nasty things like
>> implicitly cast a literal to a char *.
>>
>
> Hmm, I used int for that first but typing npt=off seemed more
> userfriendly to me than npt=0. So I used char* for it.
>
I expect this to be rarely used by users, so the simpler int is
preferable (and also consistent with vmx's bypass_guest_pf and enable_vpid).
--
Any sufficiently difficult bug is indistinguishable from a feature.
next prev parent reply other threads:[~2008-01-26 18:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 20:53 [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Joerg Roedel
2008-01-25 20:53 ` [PATCH 1/8] SVM: move feature detection to hardware setup code Joerg Roedel
2008-01-25 20:53 ` [PATCH 2/8] SVM: add detection of Nested Paging feature Joerg Roedel
2008-01-25 20:53 ` [PATCH 3/8] SVM: add module parameter to disable Nested Paging Joerg Roedel
2008-01-25 21:35 ` [kvm-devel] " Anthony Liguori
2008-01-25 22:10 ` Joerg Roedel
2008-01-26 18:38 ` Avi Kivity [this message]
2008-01-26 1:47 ` [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging Nakajima, Jun
2008-01-26 7:25 ` Joerg Roedel
2008-01-26 9:49 ` Alexey Eremenko
2008-01-26 10:06 ` Joerg Roedel
2008-01-26 16:36 ` Anthony Liguori
2008-01-26 18:23 ` Avi Kivity
2008-01-25 20:53 ` [PATCH 4/8] X86: export information about NPT to generic x86 code Joerg Roedel
2008-01-25 21:37 ` [kvm-devel] " Anthony Liguori
2008-01-25 21:40 ` Anthony Liguori
2008-01-27 8:40 ` Avi Kivity
2008-01-25 20:53 ` [PATCH 5/8] MMU: make the __nonpaging_map function generic Joerg Roedel
2008-01-25 20:53 ` [PATCH 6/8] X86: export the load_pdptrs() function to modules Joerg Roedel
2008-01-25 20:53 ` [PATCH 7/8] MMU: add HAP support to the KVM MMU Joerg Roedel
2008-01-25 20:53 ` [PATCH 8/8] SVM: add support for Nested Paging Joerg Roedel
2008-01-27 8:52 ` [kvm-devel] " Avi Kivity
2008-01-27 9:41 ` Joerg Roedel
2008-01-27 9:51 ` Avi Kivity
2008-01-27 10:05 ` Joerg Roedel
2008-01-27 10:24 ` Avi Kivity
2008-01-25 21:32 ` [kvm-devel] [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Anthony Liguori
2008-01-25 22:47 ` Joerg Roedel
2008-01-26 1:57 ` Nakajima, Jun
2008-01-27 8:57 ` Avi Kivity
2008-01-27 9:51 ` Joerg Roedel
2008-01-28 3:20 ` Jeremy Fitzhardinge
2008-01-28 11:08 ` Avi Kivity
2008-02-07 12:09 ` Joerg Roedel
2008-02-10 10:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479B7E2B.9080702@qumranet.com \
--to=avi@qumranet.com \
--cc=anthony@codemonkey.ws \
--cc=joerg.roedel@amd.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox