From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 5/9] x86: Unify strings in arch/x86/boot/compressed/misc_??.c
Date: Sat, 26 Jan 2008 17:11:21 -0800 [thread overview]
Message-ID: <479BDA39.1060907@zytor.com> (raw)
In-Reply-To: <86802c440801261703k22b6a51ft6254690f3b211efb@mail.gmail.com>
Yinghai Lu wrote:
>>
>> diff --git a/arch/x86/boot/compressed/misc_64.c b/arch/x86/boot/compressed/misc_64.c
>> index 8c1573b..bd822b7 100644
>> --- a/arch/x86/boot/compressed/misc_64.c
>> +++ b/arch/x86/boot/compressed/misc_64.c
>> @@ -372,8 +372,8 @@ asmlinkage void decompress_kernel(void *rmode, unsigned long heap,
>> error("Destination address too large");
>>
>> makecrc();
>> - putstr(".\nDecompressing Linux...");
>> + putstr("Uncompressing Linux... ");
>> gunzip();
>> - putstr("done.\nBooting the kernel.\n");
>> + putstr("Ok, booting the kernel.\n");
>> return;
>> }
>
> 64 bit old print out seem more clear. again can you change that in misc_32.c
>
Yes, except for the odd stray dot.
-hpa
next prev parent reply other threads:[~2008-01-27 1:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 11:54 [PATCH 1/9] x86: Unify whitespace and comments in arch/x86/boot/compressed/vmlinux_??.lds Ian Campbell
2008-01-26 11:54 ` [PATCH 2/9] x86: Unify whitespace in arch/x86/boot/compressed/vmlinux_??.scr Ian Campbell
2008-01-26 11:54 ` [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr Ian Campbell
2008-01-27 0:59 ` Yinghai Lu
2008-01-27 22:04 ` Ian Campbell
2008-01-27 22:57 ` H. Peter Anvin
2008-01-27 23:38 ` Yinghai Lu
2008-01-28 0:33 ` H. Peter Anvin
2008-01-28 1:49 ` Yinghai Lu
2008-01-28 1:55 ` H. Peter Anvin
2008-01-26 11:54 ` [PATCH 4/9] x86_64: Unify arch/x86/boot/compressed/vmlinux_??.scr Ian Campbell
2008-01-26 11:54 ` [PATCH 5/9] x86: Unify strings in arch/x86/boot/compressed/misc_??.c Ian Campbell
2008-01-27 1:03 ` Yinghai Lu
2008-01-27 1:11 ` H. Peter Anvin [this message]
2008-01-26 11:54 ` [PATCH 6/9] x86: Unify whitespace and comments " Ian Campbell
2008-01-26 11:54 ` [PATCH 7/9] x86: Unify headers " Ian Campbell
2008-01-26 11:54 ` [PATCH 8/9] x86: Unify variable names " Ian Campbell
2008-01-26 11:54 ` [PATCH 9/9] x86: Unify arch/x86/boot/compressed/misc_??.c Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479BDA39.1060907@zytor.com \
--to=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox