Re: [RFC PATCH] KGDB: various refactorings

Jan Kiszka
2008-01-27T19:04:42Z

[-- Attachment #1: Type: text/plain, Size: 2237 bytes --]

Jan Kiszka wrote:
> Jason,
>
> this is a RFC about another round of refactoring for the KGDB version
> in x86-git. It's a single patch so far, but I can break out individual
> hunks on request.
>
> Things I changed:
> - Reduce EXPORT_SYMBOLs, switch the rest to EXPORT_SYMBOL_GPL
> - Drop code that is (yet) unused
> - Rename variables, refactor their types (personal taste, for sure)
> - Remove "extern" for function prototypes
> - Remove MODULE_LICENSE/DESCRIPTION from kgdb core

Sorry, forgot to refresh for this hunk:

- rename CHECK_EXCEPTION_STACK to EXCEPTION_STACK_READY

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>

---
include/asm-x86/kgdb.h | 2 +-
include/linux/kgdb.h | 4 ++--
kernel/kgdb.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

Index: b/include/asm-x86/kgdb.h
===================================================================
--- a/include/asm-x86/kgdb.h
+++ b/include/asm-x86/kgdb.h
@@ -77,7 +77,7 @@ enum regnames { _AX, /* 0 */
#ifndef __ASSEMBLY__
#define BREAKPOINT() asm(" int $3");
#ifndef CONFIG_X86_32
-#define CHECK_EXCEPTION_STACK()
((&__get_cpu_var(init_tss))[0].x86_tss.ist[0])
+#define EXCEPTION_STACK_READY()
((&__get_cpu_var(init_tss))[0].x86_tss.ist[0])
#endif /* ! CONFIG_X86_32 */
#define BREAK_INSTR_SIZE 1
#define CACHE_FLUSH_IS_SAFE 1
Index: b/include/linux/kgdb.h
===================================================================
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -23,8 +23,8 @@
#include <linux/linkage.h>
#include <linux/init.h>

-#ifndef CHECK_EXCEPTION_STACK
-#define CHECK_EXCEPTION_STACK() 1
+#ifndef EXCEPTION_STACK_READY
+#define EXCEPTION_STACK_READY() 1
#endif

struct tasklet_struct;
Index: b/kernel/kgdb.c
===================================================================
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -1940,7 +1940,7 @@ static void __init kgdb_early_entry(void
* architecture to hook in and look at us when they are ready.
*/

- if (!CHECK_EXCEPTION_STACK()) {
+ if (!EXCEPTION_STACK_READY()) {
kgdb_state = KGDB_SEMI_INITIALIZED;
/* any kind of break point is deferred to late_init */
return;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]