From: Ian Abbott <abbotti@mev.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
pcihpd-discuss@lists.sourceforge.net, gregkh@suse.de,
kristen.c.accardi@intel.com
Subject: Re: [PATCH(v3) 2.6.24] Fix fakephp deadlock
Date: Mon, 28 Jan 2008 10:33:41 +0000 [thread overview]
Message-ID: <479DAF85.5020202@mev.co.uk> (raw)
In-Reply-To: <20080126220101.9e767f41.akpm@linux-foundation.org>
On 27/01/08 06:01, Andrew Morton wrote:
> Adding a deferred-work like this just because we can't get the locking and
> refcounting correct is a really sad hack.
True, but some would argue that the fakephp driver itself was a really
sad hack. :-)
> Can we get the locking and refcounting right please? Start by making that
> wait-for-refcount-to-go-away go away.
I guess that stuff was added for a good reason and fixed other potential
problems - it just broke fakephp. It's an unusual requirement to try
and support -- a file that self-destructs when you write to it. Are
there any other cases in sysfs that do that?
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2008-01-28 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 16:23 [PATCH(v3) 2.6.24] Fix fakephp deadlock Ian Abbott
2008-01-27 6:01 ` Andrew Morton
2008-01-28 10:33 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479DAF85.5020202@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox