From: Pavel Emelyanov <xemul@openvz.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vinay Sridhar <vinay@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, libc-alpha@sourceware.org,
drepper@redhat.com, wli@holomorphy.com, sripathik@in.ibm.com
Subject: Re: [RFC] Per-thread getrusage
Date: Tue, 29 Jan 2008 11:29:53 +0300 [thread overview]
Message-ID: <479EE401.2020309@openvz.org> (raw)
In-Reply-To: <m1ve5dheax.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> Pavel Emelyanov <xemul@openvz.org> writes:
>>> ...
>>> +asmlinkage long sys_thread_getrusage(int tid, struct rusage __user *ru)
>>> +{
>>> + struct task_struct *tsk;
>>> + tsk = find_task_by_pid(tid);
>>> + return getrusage(tsk, RUSAGE_THREAD, ru);
>>> +}
>> Well, the find_task_by_pid() is really wrong here.
>
> And find_task_by_pid should probably just be removed.
>
> No need to provide function with the gun firmly pointed at our feet....
We are working to uncock it. If you feel you know how to do it
faster, it would be just terrific to review your patches.
> Eric
>
next prev parent reply other threads:[~2008-01-29 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 8:27 [RFC] Per-thread getrusage Vinay Sridhar
2008-01-17 15:42 ` Ulrich Drepper
2008-01-19 1:14 ` Roland McGrath
2008-01-19 1:14 ` [PATCH] RUSAGE_THREAD Roland McGrath
2008-01-19 6:21 ` Ulrich Drepper
2008-01-21 9:55 ` Christoph Hellwig
2008-01-26 7:23 ` Michael Kerrisk
2008-01-28 5:52 ` [RFC] Per-thread getrusage Andrew Morton
2008-01-28 7:48 ` Pavel Emelyanov
2008-01-28 9:10 ` Andrew Morton
2008-01-28 9:38 ` Pavel Emelyanov
2008-01-28 9:45 ` Andrew Morton
2008-01-28 9:57 ` Pavel Emelyanov
2008-01-28 20:43 ` Eric W. Biederman
2008-01-28 21:57 ` Andrew Morton
2008-01-29 8:17 ` Pavel Emelyanov
2008-01-29 8:29 ` Pavel Emelyanov [this message]
2008-01-28 8:24 ` Sripathi Kodi
2008-01-28 9:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479EE401.2020309@openvz.org \
--to=xemul@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=drepper@redhat.com \
--cc=ebiederm@xmission.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sripathik@in.ibm.com \
--cc=vinay@linux.vnet.ibm.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox