From: Jiri Slaby <jirislaby@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Bryan Wu <bryan.wu@analog.com>,
linux-kernel@vger.kernel.org,
Mike Frysinger <michael.frysinger@analog.com>
Subject: Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory
Date: Wed, 30 Jan 2008 14:38:22 +0100 [thread overview]
Message-ID: <47A07DCE.5010808@gmail.com> (raw)
In-Reply-To: <8bd0f97a0801300519g22c5b66fjcba22a027e7043cc@mail.gmail.com>
On 01/30/2008 02:19 PM, Mike Frysinger wrote:
> On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
>> On 01/30/2008 11:36 AM, Bryan Wu wrote:
>>> + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1);
>>> + if (ret) {
>>> + unregister_chrdev_region(bfin_otp_dev_node, 1);
>>> + printk(KERN_ERR PFX "unable to register char device\n");
>>> + return ret;
>>> + }
>>> +
>>> + bfin_otp_class = class_create(THIS_MODULE, "otp");
>>> + device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
>> Anyway, wouldn't be easier/better to use misc.c functionality here
>> (misc_register() et al.)?
>
> probably ... i just didnt want to statically allocate a number in the
> range that would be Blackfin specific ...
MISC_DYNAMIC_MINOR is definitely your friend ;).
next prev parent reply other threads:[~2008-01-30 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 10:36 [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory Bryan Wu
2008-01-30 11:00 ` Jiri Slaby
2008-01-30 12:39 ` Robin Getz
2008-01-30 13:08 ` Jiri Slaby
2008-01-30 13:15 ` Bryan Wu
2008-01-30 13:43 ` Jiri Slaby
2008-01-30 13:53 ` Jiri Slaby
2008-01-30 13:19 ` Mike Frysinger
2008-01-30 13:38 ` Jiri Slaby [this message]
2008-01-30 13:41 ` Mike Frysinger
2008-02-05 18:59 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A07DCE.5010808@gmail.com \
--to=jirislaby@gmail.com \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.frysinger@analog.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).