From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Adrian Bunk <bunk@kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: arch/x86/kernel/test_nx.c compile error
Date: Wed, 30 Jan 2008 11:06:43 -0800 [thread overview]
Message-ID: <47A0CAC3.1080107@zytor.com> (raw)
In-Reply-To: <20080130184432.GA31485@elte.hu>
Ingo Molnar wrote:
>
> Index: linux-x86.q/arch/x86/kernel/test_nx.c
> ===================================================================
> --- linux-x86.q.orig/arch/x86/kernel/test_nx.c
> +++ linux-x86.q/arch/x86/kernel/test_nx.c
> @@ -91,8 +91,13 @@ static noinline int test_address(void *a
> ".previous\n"
> ".section __ex_table,\"a\"\n"
> " .align 8\n"
> +#ifdef CONFIG_X86_32
> + " .long 0b\n"
> + " .long 2b\n"
> +#endif
> " .quad 0b\n"
> " .quad 2b\n"
> +#else
> ".previous\n"
> : [rslt] "=r" (result)
> : [fake_code] "r" (address), [zero] "r" (0UL), "0" (result)
#include <asm/asm>
...
_ASM_PTR "0b\n"
_ASM_PTR "2b\n"
...
... then you don't need any #ifdef at all..
prev parent reply other threads:[~2008-01-30 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 18:25 arch/x86/kernel/test_nx.c compile error Adrian Bunk
2008-01-30 18:42 ` Ingo Molnar
2008-01-30 18:44 ` Ingo Molnar
2008-01-30 18:59 ` Ingo Molnar
2008-01-30 19:00 ` Adrian Bunk
2008-01-30 19:08 ` Ingo Molnar
2008-01-30 19:06 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A0CAC3.1080107@zytor.com \
--to=hpa@zytor.com \
--cc=arjan@linux.intel.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox