From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [12/12] GBPAGES: Switch direct mapping setup over to set_pte
Date: Fri, 01 Feb 2008 09:37:31 -0800 [thread overview]
Message-ID: <47A358DB.4010602@goop.org> (raw)
In-Reply-To: <20080201095325.6419E1B416F@basil.firstfloor.org>
Andi Kleen wrote:
> [Actually not needed for gbpages, but an indepedent, but related cleanup]
>
> Use set_pte() for setting up the 2MB pages in the direct mapping similar
> to what the earlier GBPAGES patches did for the 1GB PUDs.
>
> Signed-off-by: Andi Kleen <ak@suse.de>
>
> ---
> arch/x86/mm/init_64.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Index: linux/arch/x86/mm/init_64.c
> ===================================================================
> --- linux.orig/arch/x86/mm/init_64.c
> +++ linux/arch/x86/mm/init_64.c
> @@ -289,7 +289,6 @@ phys_pmd_init(pmd_t *pmd_page, unsigned
> int i = pmd_index(address);
>
> for (; i < PTRS_PER_PMD; i++, address += PMD_SIZE) {
> - unsigned long entry;
> pmd_t *pmd = pmd_page + pmd_index(address);
>
> if (address >= end) {
> @@ -303,9 +302,8 @@ phys_pmd_init(pmd_t *pmd_page, unsigned
> if (pmd_val(*pmd))
> continue;
>
> - entry = __PAGE_KERNEL_LARGE|_PAGE_GLOBAL|address;
> - entry &= __supported_pte_mask;
> - set_pmd(pmd, __pmd(entry));
> + set_pte((pte_t *)pmd,
> + pfn_pte(address >> PAGE_SHIFT, PAGE_KERNEL_LARGE));
>
Why? 64-bit Xen will need this to be set_pmd if its an update to L2 of
the table.
J
next prev parent reply other threads:[~2008-02-01 17:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 9:53 [PATCH] [0/12] GBPAGES patchkit for 2.6.25 v3 Andi Kleen
2008-02-01 9:53 ` [PATCH] [1/12] GBPAGES: Add feature macros for the gbpages cpuid bit Andi Kleen
2008-02-01 9:53 ` [PATCH] [2/12] GBPAGES: Rename LARGE_PAGE_SIZE to PMD_PAGE_SIZE Andi Kleen
2008-02-01 9:53 ` [PATCH] [3/12] GBPAGES: Add PUD_PAGE_SIZE Andi Kleen
2008-02-01 9:53 ` [PATCH] [4/12] Add pgtable accessor functions for GB pages Andi Kleen
2008-02-01 9:53 ` [PATCH] [5/12] GBPAGES: Support gbpages in pagetable dump Andi Kleen
2008-02-01 9:53 ` [PATCH] [6/12] GBPAGES: Add gbpages support to lookup_address Andi Kleen
2008-02-01 9:53 ` [PATCH] [7/12] GBPAGES: Add an option to disable direct mapping gbpages and a global variable Andi Kleen
2008-02-05 22:41 ` Randy Dunlap
2008-02-01 9:53 ` [PATCH] [8/12] GBPAGES: Implement gbpages support in change_page_attr() Andi Kleen
2008-02-01 9:53 ` [PATCH] [9/12] GBPAGES: Switch pci-gart over to using cpa instead of clear_kernel_mapping Andi Kleen
2008-02-01 9:53 ` [PATCH] [10/12] GBPAGES: Remove now unused clear_kernel_mapping Andi Kleen
2008-02-01 9:53 ` [PATCH] [11/12] GBPAGES: Do kernel direct mapping at boot using GB pages Andi Kleen
2008-02-01 9:53 ` [PATCH] [12/12] GBPAGES: Switch direct mapping setup over to set_pte Andi Kleen
2008-02-01 17:37 ` Jeremy Fitzhardinge [this message]
2008-02-01 17:58 ` Andi Kleen
2008-02-01 19:16 ` Jeremy Fitzhardinge
2008-02-01 12:25 ` [PATCH] [0/12] GBPAGES patchkit for 2.6.25 v3 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A358DB.4010602@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox