Re: [Patch 1/6] Enhanced partition statistics: core statistics

Jens Axboe
2008-02-08T10:07:03Z

On Fri, Feb 01 2008, Jerome Marchand wrote:
> This patch contain the core infrastructure of enhanced partition
> statistics. It adds to struct hd_struct the same stats data as struct
> gendisk and define basics function to manipulate them.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> ---
> include/linux/genhd.h | 132 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 131 insertions(+), 1 deletion(-)
> diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6.orig/include/linux/genhd.h linux-2.6/include/linux/genhd.h
> --- linux-2.6.orig/include/linux/genhd.h 2008-01-31 16:43:28.000000000 +0100
> +++ linux-2.6/include/linux/genhd.h 2008-01-31 16:47:12.000000000 +0100
> @@ -101,6 +101,13 @@ struct hd_struct {
> #ifdef CONFIG_FAIL_MAKE_REQUEST
> int make_it_fail;
> #endif
> + unsigned long stamp;
> + int in_flight;
> +#ifdef CONFIG_SMP
> + struct disk_stats *dkstats;
> +#else
> + struct disk_stats dkstats;
> +#endif
> };

This wont work on !CONFIG_SMP, since the disk_stats structure definition
is below that point. I moved it up.

Committed 1-6, thanks. But please remember to test UP configs too :)

--
Jens Axboe