public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
	Jan Beulich <jbeulich@novell.com>,
	Eduardo Pereira Habkost <ehabkost@redhat.com>,
	Ian Campbell <ijc@hellion.org.uk>, H Peter Anvin <hpa@zytor.com>
Subject: Re: [PATCH 6 of 7] x86: move pud/pgd functions into common	asm/pgalloc.h
Date: Sat, 02 Feb 2008 02:20:46 -0800	[thread overview]
Message-ID: <47A443FE.6040900@goop.org> (raw)
In-Reply-To: <20080202101356.GA19782@elte.hu>

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Common definitions for 4-level pagetable functions.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>> ---
>>  arch/x86/mm/pgtable.c        |    7 ++++++
>>  include/asm-x86/pgalloc.h    |   46 ++++++++++++++++++++++++++++++++++++------
>>  include/asm-x86/pgalloc_32.h |   24 ---------------------
>>  include/asm-x86/pgalloc_64.h |   32 -----------------------------
>>  4 files changed, 47 insertions(+), 62 deletions(-)
>>     
>
> random-qa found an early bootup hang on 32-bit (config attached).
>   

The config you sent was 64-bit.

> i bisected it down to this patch of yours. It's a bit large so it's not 
> obvious what is happening. Could you please keep patches that do 
> functional changes smaller?

Will do, though this one is more or less pure code motion.  But I can 
make it actual pure code motion with a separate merge patch.

    J

  parent reply	other threads:[~2008-02-02 10:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-02  9:05 [PATCH 0 of 7] x86: more pgalloc unification Jeremy Fitzhardinge
2008-02-02  9:05 ` [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines Jeremy Fitzhardinge
2008-02-02  9:13   ` Harvey Harrison
2008-02-02  9:17     ` Ingo Molnar
2008-02-02  9:05 ` [PATCH 2 of 7] x86: add common mm/pgtable.c Jeremy Fitzhardinge
2008-02-02 10:30   ` Ingo Molnar
2008-02-02 11:49     ` Jeremy Fitzhardinge
2008-02-02 13:47       ` Ingo Molnar
2008-02-02 16:25         ` Jeremy Fitzhardinge
2008-02-02 17:29           ` Ingo Molnar
2008-02-02 18:21             ` Jeremy Fitzhardinge
2008-02-02  9:05 ` [PATCH 3 of 7] x86: put paravirt stubs into common asm/pgalloc.h Jeremy Fitzhardinge
2008-02-02  9:05 ` [PATCH 4 of 7] x86: move pte functions " Jeremy Fitzhardinge
2008-02-02  9:21   ` Ingo Molnar
2008-02-02  9:05 ` [PATCH 5 of 7] x86: move pmd " Jeremy Fitzhardinge
2008-02-02  9:05 ` [PATCH 6 of 7] x86: move pud/pgd " Jeremy Fitzhardinge
2008-02-02 10:13   ` Ingo Molnar
2008-02-02 10:14     ` Ingo Molnar
2008-02-02 10:20     ` Jeremy Fitzhardinge [this message]
2008-02-02 10:40       ` Ingo Molnar
2008-02-02 11:49         ` Jeremy Fitzhardinge
2008-02-02 10:21     ` Ingo Molnar
2008-02-02  9:05 ` [PATCH 7 of 7] x86: move all the pgd_list handling to one place Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A443FE.6040900@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=hpa@zytor.com \
    --cc=ijc@hellion.org.uk \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox