Re: [PATCH 6 of 7] x86: move pud/pgd functions into common asm/pgalloc.h

Jeremy Fitzhardinge
2008-02-02T10:21:43Z

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> Common definitions for 4-level pagetable functions.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>> ---
>> arch/x86/mm/pgtable.c | 7 ++++++
>> include/asm-x86/pgalloc.h | 46 ++++++++++++++++++++++++++++++++++++------
>> include/asm-x86/pgalloc_32.h | 24 ---------------------
>> include/asm-x86/pgalloc_64.h | 32 -----------------------------
>> 4 files changed, 47 insertions(+), 62 deletions(-)
>>
>
> random-qa found an early bootup hang on 32-bit (config attached).
>

The config you sent was 64-bit.

> i bisected it down to this patch of yours. It's a bit large so it's not
> obvious what is happening. Could you please keep patches that do
> functional changes smaller?

Will do, though this one is more or less pure code motion. But I can
make it actual pure code motion with a separate merge patch.

J