From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932455AbYBBSWY (ORCPT ); Sat, 2 Feb 2008 13:22:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751995AbYBBSWP (ORCPT ); Sat, 2 Feb 2008 13:22:15 -0500 Received: from gw.goop.org ([64.81.55.164]:46923 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbYBBSWO (ORCPT ); Sat, 2 Feb 2008 13:22:14 -0500 Message-ID: <47A4B4A4.3050509@goop.org> Date: Sat, 02 Feb 2008 10:21:24 -0800 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ingo Molnar CC: LKML , Andi Kleen , Jan Beulich , Eduardo Pereira Habkost , Ian Campbell , H Peter Anvin Subject: Re: [PATCH 2 of 7] x86: add common mm/pgtable.c References: <3c9aba41ee700a239859.1201943114@localhost> <20080202103030.GA23897@elte.hu> <47A458B1.4050208@goop.org> <20080202134714.GA925@elte.hu> <47A49974.4040504@goop.org> <20080202172921.GA24961@elte.hu> In-Reply-To: <20080202172921.GA24961@elte.hu> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Jeremy Fitzhardinge wrote: > > >> Ingo Molnar wrote: >> >>> oops, i thought i pasted that. It was this: >>> >>> arch/x86/mm/pgtable.c: In function 'pgd_alloc': >>> arch/x86/mm/pgtable.c:213: error: implicit declaration of function 'quicklist_alloc' >>> arch/x86/mm/pgtable.c:213: warning: initialization makes pointer from integer without a cast >>> arch/x86/mm/pgtable.c:218: error: implicit declaration of function 'quicklist_free' >>> arch/x86/mm/pgtable.c: In function 'check_pgt_cache': >>> arch/x86/mm/pgtable.c:233: error: implicit declaration of function 'quicklist_trim' >>> >>> also, config re-attached. (maybe i messed up the previous one) >>> >> Still can't reproduce, but it's a simple case of missing headers. >> > > ok, i'll figure it out if/when it happens with your resent queue. > I added an explict to pgtable.c, so there's no excuse to still complain. Will resend the combined series shortly. J