From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
git-commits-head@vger.kernel.org
Subject: Re: x86: fix arch/x86/kernel/test_nx.c modular build bug
Date: Sat, 02 Feb 2008 15:12:49 -0800 [thread overview]
Message-ID: <47A4F8F1.2020708@zytor.com> (raw)
In-Reply-To: <20080202223645.GA27546@uranus.ravnborg.org>
Sam Ravnborg wrote:
>
> This should have used _ASM_PTR from asm.h:
>
> #ifdef CONFIG_X86_32
> /* 32 bits */
>
> # define _ASM_PTR " .long "
> ...
> #else
> /* 64 bits */
>
> # define _ASM_PTR " .quad "
>
There is an even better patch now in upstream.
-hpa
next prev parent reply other threads:[~2008-02-02 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200801310159.m0V1xU2L015772@hera.kernel.org>
2008-02-02 22:36 ` x86: fix arch/x86/kernel/test_nx.c modular build bug Sam Ravnborg
2008-02-02 23:12 ` H. Peter Anvin [this message]
2008-02-02 23:54 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A4F8F1.2020708@zytor.com \
--to=hpa@zytor.com \
--cc=git-commits-head@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox