From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936233AbYBCDB6 (ORCPT ); Sat, 2 Feb 2008 22:01:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936038AbYBCDA4 (ORCPT ); Sat, 2 Feb 2008 22:00:56 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:59820 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S935942AbYBCDAs (ORCPT ); Sat, 2 Feb 2008 22:00:48 -0500 Message-ID: <47A52E20.7000608@cn.fujitsu.com> Date: Sun, 03 Feb 2008 10:59:44 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Andrew Morton CC: jirislaby@gmail.com, LKML Subject: [PATCH] mxser: fix compile warning building without CONFIG_PCI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When build without CONFIG_PIC, got the following warnings: drivers/char/mxser.c: In function 'mxser_init': drivers/char/mxser.c:698: warning: unused variable 'devnum' drivers/char/mxser.c:698: warning: unused variable 'busnum' drivers/char/mxser.c:697: warning: unused variable 'index' drivers/char/mxser.c:696: warning: unused variable 'pdev' drivers/char/mxser.c:695: warning: unused variable 'n' Signed-off-by: Li Zefan --- drivers/char/mxser.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index fd0abef..b2cc93d 100644 --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -692,10 +692,7 @@ static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxs static int mxser_init(void) { - int i, m, retval, b, n; - struct pci_dev *pdev = NULL; - int index; - unsigned char busnum, devnum; + int i, m, retval, b; struct mxser_hwconf hwconf; mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1); @@ -834,10 +831,11 @@ static int mxser_init(void) /* start finding PCI board here */ #ifdef CONFIG_PCI - n = ARRAY_SIZE(mxser_pcibrds) - 1; - index = 0; b = 0; - while (b < n) { + while (b < ARRAY_SIZE(mxser_pcibrds)-1) { + unsigned char busnum, devnum; + struct pci_dev *pdev; + pdev = pci_get_device(mxser_pcibrds[b].vendor, mxser_pcibrds[b].device, pdev); if (pdev == NULL) { @@ -850,7 +848,7 @@ static int mxser_init(void) printk(KERN_INFO "Found MOXA %s board(BusNo=%d,DevNo=%d)\n", mxser_brdname[(int) (mxser_pcibrds[b].driver_data) - 1], busnum, devnum >> 3); - index++; + if (m >= MXSER_BOARDS) printk(KERN_ERR "Too many Smartio/Industio family boards find " -- 1.5.4.rc3