From: Jeff Garzik <jeff@garzik.org>
To: Peter Teoh <htmldeveloper@gmail.com>
Cc: Wenji Huang <wenji.huang@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: LPFC compilation error in 2.6.24-git12/git13
Date: Sun, 03 Feb 2008 12:35:20 -0500 [thread overview]
Message-ID: <47A5FB58.8040404@garzik.org> (raw)
In-Reply-To: <804dabb00802030325v12cb95cen75179941fa4443cb@mail.gmail.com>
Peter Teoh wrote:
> --- lpfc_init.c.old 2008-02-03 19:26:20.000000000 +0800
> +++ drivers/scsi/lpfc/lpfc_init.c 2008-02-03 19:26:42.000000000 +0800
> @@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
> uint16_t iotag;
> int bars = pci_select_bars(pdev, IORESOURCE_MEM);
>
> - if (pci_enable_device_bars(pdev, bars))
> + if (pci_enable_device_io(pdev))
> goto out;
As already discussed and pointed out on LKML and linux-scsi, this is the
wrong change. Look at the line above the one you changed -- we want mem
not io.
Jeff
prev parent reply other threads:[~2008-02-03 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 9:36 LPFC compilation error in 2.6.24-git12/git13 Wenji Huang
2008-02-03 11:20 ` Peter Teoh
2008-02-03 11:25 ` Peter Teoh
2008-02-03 17:35 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A5FB58.8040404@garzik.org \
--to=jeff@garzik.org \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox