From: Timur Tabi <timur@freescale.com>
To: Roel Kluin <12o3l@tiscali.nl>, Timur Tabi <timur@freescale.com>,
liam.girdwood@wolfsonmicro.com, alsa-devel@alsa-project.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate strcasecmp test for "rj-master" in mpc8610_hpcd_probe()
Date: Mon, 04 Feb 2008 17:17:29 -0600 [thread overview]
Message-ID: <47A79D09.6090806@freescale.com> (raw)
In-Reply-To: <20080204231114.GA7842@sirena.org.uk>
Mark Brown wrote:
> On Mon, Feb 04, 2008 at 10:08:02PM +0100, Roel Kluin wrote:
>> In linus' git tree I found this problem. Is it also in the alsa tree?
>> please confirm it's the right fix. The patch was not yet tested.
>
> Timur, this looks like a good catch?
Yes, thank you! The change below should be made.
>
>> --
>> duplicate test for "rj-master"
>>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>> ---
>> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
>> index f26c4b2..a00aac7 100644
>> --- a/sound/soc/fsl/mpc8610_hpcd.c
>> +++ b/sound/soc/fsl/mpc8610_hpcd.c
>> @@ -314,9 +314,9 @@ static int mpc8610_hpcd_probe(struct of_device *ofdev,
>> } else if (strcasecmp(sprop, "lj-master") == 0) {
>> machine_data->dai_format = SND_SOC_DAIFMT_LEFT_J;
>> machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
>> machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
>> - } else if (strcasecmp(sprop, "rj-master") == 0) {
>> + } else if (strcasecmp(sprop, "rj-slave") == 0) {
>> machine_data->dai_format = SND_SOC_DAIFMT_RIGHT_J;
>> machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
>> machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
>> } else if (strcasecmp(sprop, "rj-master") == 0) {
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-02-04 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 21:08 [PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate strcasecmp test for "rj-master" in mpc8610_hpcd_probe() Roel Kluin
2008-02-04 23:11 ` [alsa-devel] " Mark Brown
2008-02-04 23:17 ` Timur Tabi [this message]
2008-02-05 10:19 ` [PATCH] " Mark Brown
2008-02-06 7:27 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A79D09.6090806@freescale.com \
--to=timur@freescale.com \
--cc=12o3l@tiscali.nl \
--cc=alsa-devel@alsa-project.org \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox