From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756067AbYBEFIq (ORCPT ); Tue, 5 Feb 2008 00:08:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751466AbYBEFIh (ORCPT ); Tue, 5 Feb 2008 00:08:37 -0500 Received: from sinclair.provo.novell.com ([137.65.248.137]:21447 "EHLO sinclair.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbYBEFIg convert rfc822-to-8bit (ORCPT ); Tue, 5 Feb 2008 00:08:36 -0500 Message-Id: <47A7A784.BA47.005A.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0.2 HP Date: Mon, 04 Feb 2008 22:02:12 -0700 From: "Gregory Haskins" To: "Daniel Walker" , "Max Krasnyanskiy" Cc: "Ingo Molnar" , "LKML" , Subject: Re: CPU hotplug and IRQ affinity with 2.6.24-rt1 References: <47A7A131.8040800@qualcomm.com> <20080205025144.GA31774@dwalker1.mvista.com> In-Reply-To: <20080205025144.GA31774@dwalker1.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On Mon, Feb 4, 2008 at 9:51 PM, in message <20080205025144.GA31774@dwalker1.mvista.com>, Daniel Walker wrote: > I get the following when I tried it, > > BUG: sleeping function called from invalid context bash(5126) at > kernel/rtmutex.c:638 > in_atomic():1 [00000001], irqs_disabled():1 Hi Daniel, Can you try this patch and let me know if it fixes your problem? ----------------------- use rcu for root-domain kfree Signed-off-by: Gregory Haskins diff --git a/kernel/sched.c b/kernel/sched.c index e6ad493..77e86c1 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -339,6 +339,7 @@ struct root_domain { atomic_t refcount; cpumask_t span; cpumask_t online; + struct rcu_head rcu; /* * The "RT overload" flag: it gets set if a CPU has more than @@ -6222,6 +6223,12 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent) return 1; } +/* rcu callback to free a root-domain */ +static void rq_free_root(struct rcu_head *rcu) +{ + kfree(container_of(rcu, struct root_domain, rcu)); +} + static void rq_attach_root(struct rq *rq, struct root_domain *rd) { unsigned long flags; @@ -6241,7 +6248,7 @@ static void rq_attach_root(struct rq *rq, struct root_domain *rd) cpu_clear(rq->cpu, old_rd->online); if (atomic_dec_and_test(&old_rd->refcount)) - kfree(old_rd); + call_rcu(&old_rd->rcu, rq_free_root); } atomic_inc(&rd->refcount);