From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760578AbYBGOk3 (ORCPT ); Thu, 7 Feb 2008 09:40:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755913AbYBGOkQ (ORCPT ); Thu, 7 Feb 2008 09:40:16 -0500 Received: from gateway-1237.mvista.com ([63.81.120.155]:40346 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754654AbYBGOkP (ORCPT ); Thu, 7 Feb 2008 09:40:15 -0500 Message-ID: <47AB1882.8060103@ru.mvista.com> Date: Thu, 07 Feb 2008 17:41:06 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Salnikov Subject: Re: [PATCH 3/3] palm_bk3710: factor out cable detection References: <200802071542.29628.bzolnier@gmail.com> In-Reply-To: <200802071542.29628.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > Factor out cable detection to palm_bk3710_cable_detect(). > Cc: Anton Salnikov > Signed-off-by: Bartlomiej Zolnierkiewicz > Index: b/drivers/ide/arm/palm_bk3710.c > =================================================================== > --- a/drivers/ide/arm/palm_bk3710.c > +++ b/drivers/ide/arm/palm_bk3710.c > @@ -311,6 +311,12 @@ static void __devinit palm_bk3710_chipin > palm_bk3710_setpiomode(base, NULL, 0, 600, 0); > palm_bk3710_setpiomode(base, NULL, 1, 600, 0); > } > + > +static u8 __devinit palm_bk3710_cable_detect(ide_hwif_t *hwif) > +{ > + return ATA_CBL_PATA80; > +} > + > static int __devinit palm_bk3710_probe(struct platform_device *pdev) > { > struct clk *clkp; > @@ -381,7 +387,7 @@ static int __devinit palm_bk3710_probe(s > hwif->set_dma_mode = &palm_bk3710_set_dma_mode; > hwif->mmio = 1; > default_hwif_mmiops(hwif); > - hwif->cbl = ATA_CBL_PATA80; > + hwif->cbl = palm_bk3710_cable_detect(hwif); > hwif->ultra_mask = 0x1f; /* Ultra DMA Mode 4 Max > (input clk 99MHz) */ > hwif->mwdma_mask = 0x7; Hm, how does it help if you don't make it into driver's method? :-O MBR, Sergei