From: Chuck Ebbert <cebbert@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: [PATCH] x86_64: make traps on 'iret' be debuggable in user space
Date: Thu, 07 Feb 2008 18:28:22 -0500 [thread overview]
Message-ID: <47AB9416.2030508@redhat.com> (raw)
In-Reply-To: <20080207203032.5BF392701AB@magilla.localdomain>
On 02/07/2008 03:30 PM, Roland McGrath wrote:
>> Did you test without CONFIG_PARAVIRT, and CONFIG_PARAVIRT booted both with and
>> without the "noreplace-paravirt" parameter?
>
> I did not test CONFIG_PARAVIRT at all. I just fixed what its introduction
> had done to break generic x86-64.
>
>
It looks you may have broken paravirt (if even that case worked) because
the iret is actually at the iret_label you removed (after the instruction
is patched.) And most likely neither version worked with "noreplace-paravirt',
because then the iret instruction is out-of-line and the INTERRUPT_RETURN
jumps to it.
next prev parent reply other threads:[~2008-02-07 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 7:51 [PATCH] x86_64: make traps on 'iret' be debuggable in user space Roland McGrath
2008-02-05 8:01 ` Ingo Molnar
2008-02-05 8:15 ` Roland McGrath
2008-02-05 8:16 ` Roland McGrath
2008-02-07 20:13 ` Chuck Ebbert
2008-02-07 20:30 ` Roland McGrath
2008-02-07 23:28 ` Chuck Ebbert [this message]
2008-02-08 0:00 ` Roland McGrath
2008-02-08 0:06 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AB9416.2030508@redhat.com \
--to=cebbert@redhat.com \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox