public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Xilinx: hwicap driver comments
@ 2008-02-07 20:08 Jiri Slaby
  2008-02-07 20:34 ` Grant Likely
                   ` (5 more replies)
  0 siblings, 6 replies; 25+ messages in thread
From: Jiri Slaby @ 2008-02-07 20:08 UTC (permalink / raw)
  To: Stephen Neuendorffer, Grant Likely
  Cc: Linux Kernel Mailing List, Andrew Morton

Hi,

first of all, I think that the driver should go through lkml before upstream 
merge or at least be in -mm for a while (I think this used to be a rule some 
time ago), correct me if I'm wrong, but none of it happened.

Few comments I have:
- release f_op retval is silently ignored, I guess you will get your device into 
undefined state when the first function fails (esp. when you interrupt the sem)
- semaphores are deprecated
- class_device_create is deprecated
- module_init/exit functions should be __init, not __devinit/exit (not a bug, 
it's subset)
- this piece:
         drvdata = kmalloc(sizeof(struct hwicap_drvdata), GFP_KERNEL);
         if (!drvdata) {
                 dev_err(dev, "Couldn't allocate device private record\n");
                 return -ENOMEM;
         }
  memset((void *)drvdata, 0, sizeof(struct hwicap_drvdata));

  kmalloc + memset = kzalloc
  null probed_devices[id] on that fail path and on failed1 label

- from/to (void *) casts are useless
- io resources are at least ulong
- don't understand this:
                 memcpy(kbuf, drvdata->read_buffer, bytes_remaining);
                 drvdata->read_buffer_in_use = bytes_remaining;
                 free_page((unsigned long)kbuf);
- can this overlap (=>memmove)?
                 memcpy(drvdata->read_buffer + bytes_to_read,
                                 drvdata->read_buffer, 4 - bytes_to_read);
- is platform probing function race-proof (like pci)?
- run sparse on it, you mix __user with non-__user at least

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2008-02-08 17:20 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-07 20:08 Xilinx: hwicap driver comments Jiri Slaby
2008-02-07 20:34 ` Grant Likely
2008-02-07 21:10   ` Stephen Neuendorffer
2008-02-07 20:42 ` Andrew Morton
2008-02-07 20:54   ` Grant Likely
2008-02-07 21:21     ` Andrew Morton
2008-02-07 21:31       ` Grant Likely
2008-02-07 21:35         ` Stephen Neuendorffer
2008-02-07 21:53           ` Andrew Morton
2008-02-07 22:00             ` Stephen Neuendorffer
2008-02-07 21:40       ` Linus Torvalds
2008-02-07 21:25     ` Benjamin Herrenschmidt
2008-02-07 21:35   ` Josh Boyer
2008-02-07 22:11     ` Andrew Morton
2008-02-07 22:58       ` Josh Boyer
2008-02-07 21:17 ` Benjamin Herrenschmidt
2008-02-07 21:28   ` Jiri Slaby
2008-02-07 21:33     ` Benjamin Herrenschmidt
2008-02-07 21:35       ` Grant Likely
2008-02-07 22:31 ` Stephen Neuendorffer
2008-02-07 22:39   ` Jiri Slaby
2008-02-08  2:17 ` [PATCH] [POWERPC] Xilinx: hwicap driver Stephen Neuendorffer
2008-02-08  9:10   ` Jiri Slaby
2008-02-08 16:49   ` Randy Dunlap
2008-02-08 17:08 ` Xilinx: hwicap driver comments Stephen Neuendorffer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox