Re: [PATCH] scsi_error: Fix language abuse.

Luben Tuikov
2008-02-09T08:02:49Z

--- On Fri, 2/8/08, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> The word "illegal" has a precise dictionary
> meaning of "prohibited by
> law". The error messages are therefore incorrect as so
> far nobody has
> made SCSI violations a criminal offence.
>
> This corrects scsi to match various other subsystems
> I've slowly been
> ridding of this.
>
> Pedantically-signed-off-by: Alan Cox
> <alan@redhat.com>

Alan,

In standards and in hardware specs, from which the meaning of
"illegal" is borrowed from (into standards), "illegal" doesn't
necessarily mean "invalid", and cannot be substituted for.
This is exactly why this particular word is used in the ASC/ASCQ
assignments. It exposes an underlying behaviour.

For example:

> - {0x2004, "Illegal command while in write capable state"},
> + {0x2004, "Invalid command while in write capable state"},

Consider this: the command itself can be very perfectly "valid",
e.g. the SCB contents, format, etc., but certainly "illegal".

Similarly for the rest of this patch.

Luben