Re: [PATCH 3/3] palm_bk3710: factor out cable detection

Sergei Shtylyov
2008-02-08T17:34:03Z

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] palm_bk3710: use struct ide_port_info

> * Factor out cable detection to palm_bk3710_cable_detect().

> * Add palm_bk3710_init_hwif() (->init_hwif method implementation).

> * Remove needless ->quirkproc initialization.

> * Add missing ->pio_mask initialization.

> * Use ATA_* defines for setting ->{ultra,mwdma}_mask.

> * Add 'struct ide_port_info palm_bk3710_port_info' and pass it to
> ide_device_add(). Then remove open-coded 'hwif' initialization.

> Cc: Anton Salnikov <asalnikov@ru.mvista.com>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei