From: "H. Peter Anvin" <hpa@zytor.com>
To: Michael Opdenacker <michael-lists@free-electrons.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, Linux-tiny@selenic.com
Subject: Re: [PATCH] x86 (Linux Tiny): configure out support for some processors
Date: Mon, 11 Feb 2008 14:59:47 -0800 [thread overview]
Message-ID: <47B0D363.1020302@zytor.com> (raw)
In-Reply-To: <200802112342.23493.michael-lists@free-electrons.com>
Michael Opdenacker wrote:
>
> Also note that for the sake of convenience and consistency
> between 32 and 64 bit, I move the declaration of force_mwait
> from kernel/cpu/amd.c to kernel/setup_32.c
> (force_mwait is already defined in kernel/setup_64.c).
>
NAK NAK NAK NAK NAK NAK NAK
This is the totally wrong thing to do. The CPU initialization stuff
should move *into* the CPU directory (unification based on the
cleaned-up 32-bit code, not on the 64-bit code which is based on a fork
of the pre-cleanup 32-bit code.)
-hpa
next prev parent reply other threads:[~2008-02-11 23:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 22:47 [PATCH] x86 (Linux Tiny): configure out support for some processors Michael Opdenacker
2008-02-08 23:04 ` H. Peter Anvin
2008-02-08 23:11 ` Ingo Molnar
2008-02-09 9:31 ` Michael Opdenacker
2008-02-11 22:42 ` Michael Opdenacker
2008-02-11 22:56 ` Matt Mackall
2008-02-11 23:01 ` H. Peter Anvin
2008-02-11 23:28 ` Matt Mackall
2008-02-12 0:54 ` H. Peter Anvin
2008-02-12 1:15 ` Matt Mackall
2008-02-15 11:00 ` [RFC] [PATCH] x86: Use ELF section to list CPU vendor specific code (Linux Tiny) Thomas Petazzoni
2008-02-17 18:14 ` Ingo Molnar
2008-02-17 19:46 ` H. Peter Anvin
2008-02-23 2:43 ` Matt Mackall
2008-02-23 3:19 ` H. Peter Anvin
2008-02-25 8:29 ` Thomas Petazzoni
2008-02-25 17:03 ` Matt Mackall
2008-02-25 17:53 ` Thomas Petazzoni
2008-02-25 17:58 ` Matt Mackall
2008-02-11 22:59 ` H. Peter Anvin [this message]
2008-02-08 23:20 ` [PATCH] x86 (Linux Tiny): configure out support for some processors Matt Mackall
2008-02-09 8:30 ` Simon Holm Thøgersen
2008-02-09 9:29 ` Michael Opdenacker
2008-02-09 10:05 ` Simon Holm Thøgersen
2008-02-09 21:35 ` H. Peter Anvin
2008-02-09 9:26 ` Michael Opdenacker
2008-02-09 3:48 ` Taral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B0D363.1020302@zytor.com \
--to=hpa@zytor.com \
--cc=Linux-tiny@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael-lists@free-electrons.com \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox