From: Benny Halevy <bhalevy@panasas.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: bug in checkpatch (on pointers to typedefs?)
Date: Tue, 12 Feb 2008 10:21:47 +0200 [thread overview]
Message-ID: <47B1571B.1090408@panasas.com> (raw)
In-Reply-To: <20080211184224.GJ11671@shadowen.org>
On Feb. 11, 2008, 20:42 +0200, Andy Whitcroft <apw@shadowen.org> wrote:
> On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
>> OK, but the return type doesn't have to be in the patched line, it could be in
>> a synchronization line or even missing if the function has a long multi-line argument
>> list.
>
> Ok, I guess thats fair criticism. Could you check out the current
> checkpatch-next (0.14-8-g3737366 or later -9, -10 etc), and see if
> that works. It seems to on the simple examples you sent me :).
Confirmed with 0.14-8-g3737366.
Thanks!
Benny
Oh, and I really liked the fact that you print the patch file name
in the summary line of each patch checked rather than "Your patch" :)
>
> Thanks.
>
> -apw
next prev parent reply other threads:[~2008-02-12 8:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 14:33 bug in checkpatch (on pointers to typedefs?) Marcin Slusarz
2008-02-11 10:23 ` Andy Whitcroft
2008-02-11 16:05 ` Benny Halevy
2008-02-11 16:40 ` Andy Whitcroft
2008-02-11 16:58 ` Benny Halevy
2008-02-11 18:42 ` Andy Whitcroft
2008-02-12 8:21 ` Benny Halevy [this message]
2008-02-11 18:09 ` Marcin Slusarz
2008-02-13 19:43 ` Jan Engelhardt
2008-02-14 10:06 ` Andy Whitcroft
2008-02-14 18:29 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B1571B.1090408@panasas.com \
--to=bhalevy@panasas.com \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox