[PATCH] [3/8] CPA: Fix some incorrect comments in the debug pagealloc code

Andi Kleen
2008-02-11T09:51:21Z

Even with the pool cpa in debug_pagealloc can fail (e.g. consider memory hotplug)
Also the code does not clear PSE anymore as the comment claims.

Replace wrong comment with correct one.
Signed-off-by: Andi Kleen <ak@suse.de>

---
arch/x86/mm/pageattr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c
+++ linux/arch/x86/mm/pageattr.c
@@ -864,10 +864,7 @@ void kernel_map_pages(struct page *page,
if (!debug_pagealloc_enabled)
return;

- /*
- * The return value is ignored - the calls cannot fail,
- * large pages are disabled at boot time:
- */
+ /* This can fail in theory but then you're out of luck */
if (enable)
__set_pages_p(page, numpages);
else