* git-x86 mm branch compile error
@ 2008-02-13 0:14 Kevin Winchester
2008-02-13 0:19 ` Kevin Winchester
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Winchester @ 2008-02-13 0:14 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: Linux Kernel Mailing List
CC arch/x86/mm/pageattr.o
arch/x86/mm/pageattr.c: In function ‘change_page_attr_set_clr’:
arch/x86/mm/pageattr.c:778: error: incompatible type for argument 1 of
‘cpa_check_alias’
make[1]: *** [arch/x86/mm/pageattr.o] Error 1
make: *** [arch/x86/mm] Error 2
at tip 5248bbad9c72dd576aa8f3b44b5a959a7cae6ce1 x86: make
DEBUG_PAGEALLOC & HIBERNATE work
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: git-x86 mm branch compile error
2008-02-13 0:14 git-x86 mm branch compile error Kevin Winchester
@ 2008-02-13 0:19 ` Kevin Winchester
2008-02-13 7:01 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Winchester @ 2008-02-13 0:19 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: Linux Kernel Mailing List
Kevin Winchester wrote:
> CC arch/x86/mm/pageattr.o
> arch/x86/mm/pageattr.c: In function ‘change_page_attr_set_clr’:
> arch/x86/mm/pageattr.c:778: error: incompatible type for argument 1 of
> ‘cpa_check_alias’
> make[1]: *** [arch/x86/mm/pageattr.o] Error 1
> make: *** [arch/x86/mm] Error 2
>
> at tip 5248bbad9c72dd576aa8f3b44b5a959a7cae6ce1 x86: make
> DEBUG_PAGEALLOC & HIBERNATE work
>
>
>
I assume the following is an acceptable fix (it will be completely
whitespace damaged due to thunderbird, but I think you get the idea)
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index cf91149..76a3de5 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -729,7 +729,7 @@ cpa_check_alias(struct cpa_data *cpa, unsigned long
addr, int numpages)
#else
static int
-cpa_check_alias(struct cpa_data cpa, unsigned long addr, int numpages)
+cpa_check_alias(struct cpa_data *cpa, unsigned long addr, int numpages)
{
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: git-x86 mm branch compile error
2008-02-13 0:19 ` Kevin Winchester
@ 2008-02-13 7:01 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2008-02-13 7:01 UTC (permalink / raw)
To: Kevin Winchester; +Cc: Ingo Molnar, Linux Kernel Mailing List
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1139 bytes --]
On Tue, 12 Feb 2008, Kevin Winchester wrote:
> Kevin Winchester wrote:
> > CC arch/x86/mm/pageattr.o
> > arch/x86/mm/pageattr.c: In function ‘change_page_attr_set_clr’:
> > arch/x86/mm/pageattr.c:778: error: incompatible type for argument 1 of
> > ‘cpa_check_alias’
> > make[1]: *** [arch/x86/mm/pageattr.o] Error 1
> > make: *** [arch/x86/mm] Error 2
> >
> > at tip 5248bbad9c72dd576aa8f3b44b5a959a7cae6ce1 x86: make
> > DEBUG_PAGEALLOC & HIBERNATE work
Sorry. I pushed the wrong branch out.
> I assume the following is an acceptable fix (it will be completely
> whitespace damaged due to thunderbird, but I think you get the idea)
Applied. Thanks,
tglx
> diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
> index cf91149..76a3de5 100644
> --- a/arch/x86/mm/pageattr.c
> +++ b/arch/x86/mm/pageattr.c
> @@ -729,7 +729,7 @@ cpa_check_alias(struct cpa_data *cpa, unsigned long
> addr, int numpages)
> #else
>
> static int
> -cpa_check_alias(struct cpa_data cpa, unsigned long addr, int numpages)
> +cpa_check_alias(struct cpa_data *cpa, unsigned long addr, int numpages)
> {
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-13 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-13 0:14 git-x86 mm branch compile error Kevin Winchester
2008-02-13 0:19 ` Kevin Winchester
2008-02-13 7:01 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox