public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Winchester <kjwinchester@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: git-x86 mm branch compile error
Date: Tue, 12 Feb 2008 20:19:08 -0400	[thread overview]
Message-ID: <47B2377C.3000207@gmail.com> (raw)
In-Reply-To: <47B2366C.4020901@gmail.com>

Kevin Winchester wrote:
>   CC      arch/x86/mm/pageattr.o
> arch/x86/mm/pageattr.c: In function ‘change_page_attr_set_clr’:
> arch/x86/mm/pageattr.c:778: error: incompatible type for argument 1 of
> ‘cpa_check_alias’
> make[1]: *** [arch/x86/mm/pageattr.o] Error 1
> make: *** [arch/x86/mm] Error 2
> 
> at tip 5248bbad9c72dd576aa8f3b44b5a959a7cae6ce1 x86: make
> DEBUG_PAGEALLOC & HIBERNATE work
> 
> 
> 

I assume the following is an acceptable fix (it will be completely
whitespace damaged due to thunderbird, but I think you get the idea)

diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index cf91149..76a3de5 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -729,7 +729,7 @@ cpa_check_alias(struct cpa_data *cpa, unsigned long
addr, int numpages)
 #else

 static int
-cpa_check_alias(struct cpa_data cpa, unsigned long addr, int numpages)
+cpa_check_alias(struct cpa_data *cpa, unsigned long addr, int numpages)
 {
        return 0;
 }

  reply	other threads:[~2008-02-13  0:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  0:14 git-x86 mm branch compile error Kevin Winchester
2008-02-13  0:19 ` Kevin Winchester [this message]
2008-02-13  7:01   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B2377C.3000207@gmail.com \
    --to=kjwinchester@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox