From: Roel Kluin <12o3l@tiscali.nl>
To: thomas@winischhofer.net, lkml <linux-kernel@vger.kernel.org>
Subject: [drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated twice
Date: Wed, 13 Feb 2008 12:00:33 +0100 [thread overview]
Message-ID: <47B2CDD1.1070406@tiscali.nl> (raw)
Not sure whether this is important, but in drivers/video/sis/init301.c:1557:
if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) {
SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2;
} else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {
SiS_Pr->SiS_LCDTypeInfo = temp >> 4;
note the duplicate test for 'SiS_Pr->ChipType >= SIS_661'
if it was true in the first test, the second test won't be evaluated.
reply other threads:[~2008-02-13 11:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2CDD1.1070406@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox