From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: ying.huang@intel.com, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/2] CPA: Fix set_memory_x for ioremap v2
Date: Wed, 13 Feb 2008 12:27:26 +0100 [thread overview]
Message-ID: <47B2D41E.6040908@suse.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0802122318090.12988@apollo.tec.linutronix.de>
> The so-called "significant restructuring" took a mere 2 hours,
> which is probably less than the time consumed in this thread.
Hmm, it doesn't do what I meant and I don't think you solved
the problem. You still check against the vaddrs
which won't work for ioremaps or fixmap (and thus not
fix the EFI cases)
What I meant with restructuring is calling lookup_address() early,
get the physical address from the PTE, then check that against
the alias ranges in physical. That would actually work for fixmaps
and ioremaps and all other mappings too.
I'm sure it can be all done, but for me it to submit such
a change would likely require weeks of thread like this so
I'm not trying.
-Andi
prev parent reply other threads:[~2008-02-13 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 12:53 [PATCH] [1/2] CPA: Fix set_memory_x for ioremap v2 Andi Kleen
2008-02-12 12:53 ` [PATCH] [2/2] Improve not NX check in i386 direct mapping setup Andi Kleen
2008-02-12 23:02 ` [PATCH] [1/2] CPA: Fix set_memory_x for ioremap v2 Thomas Gleixner
2008-02-13 11:27 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2D41E.6040908@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox