From: Brice Goglin <Brice.Goglin@inria.fr>
To: shannon.nelson@intel.com, dan.j.williams@intel.com
Cc: Chris Leech <christopher.leech@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
Date: Wed, 13 Feb 2008 22:05:12 +0100 [thread overview]
Message-ID: <47B35B88.5070300@inria.fr> (raw)
[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
---
user_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
end = start + skb_shinfo(skb)->frags[i].size;
copy = end - offset;
- if ((copy = end - offset) > 0) {
+ if (copy > 0) {
skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
struct page *page = frag->page;
next reply other threads:[~2008-02-13 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:05 Brice Goglin [this message]
2008-02-14 1:02 ` [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec Dan Williams
2008-02-14 2:29 ` Nelson, Shannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B35B88.5070300@inria.fr \
--to=brice.goglin@inria.fr \
--cc=christopher.leech@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox