From: Corey Minyard <minyard@acm.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 7/8] IPMI: convert locked counters to atomics
Date: Wed, 13 Feb 2008 18:19:02 -0600 [thread overview]
Message-ID: <47B388F6.8040202@acm.org> (raw)
In-Reply-To: <20080213152645.9e589d0c.akpm@linux-foundation.org>
Andrew Morton wrote:
> The code forgot to initialise all of these.
>
> It just so happens that the all-bits-zero pattern works correctly for all
> current architectures, so the code should work OK. But there is no reason
> (I hope) why an architecture cannot implement atomic_t as
>
> struct atomic_t {
> int counter;
> spinlock_t lock;
> };
>
> in which case the results of ATOMIC_INIT() may _not_ be all-zeroes, in
> which case the code will deadlock.
>
> So. It works, but it's grubby. Do you still wish to proceed?
>
Thanks. Don't proceed for now, I'll work up new patches.
-corey
prev parent reply other threads:[~2008-02-14 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 16:32 [PATCH 7/8] IPMI: convert locked counters to atomics Corey Minyard
2008-02-13 23:26 ` Andrew Morton
2008-02-14 0:19 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B388F6.8040202@acm.org \
--to=minyard@acm.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox