From: Andi Kleen <ak@suse.de>
To: Adrian Bunk <bunk@kernel.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] x86: make dump_pagetable() static
Date: Thu, 14 Feb 2008 08:57:48 +0100 [thread overview]
Message-ID: <47B3F47C.8010803@suse.de> (raw)
In-Reply-To: <20080213223621.GC12383@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> On Wed, Feb 13, 2008 at 02:27:47PM -0800, Harvey Harrison wrote:
>> On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote:
>>> dump_pagetable() can now become static.
>>>
>>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>>
>> I believe Andi Kleen wanted this kept global to make it easy to use when
>> adding debugging code elsewhere.
>
> That's not a reason as long as his code isn't in the tree (and he anyway
> has to patch the kernel for using it).
It was originally needed for the old cpa patchkit which dumped
the page tables when it detected an internal inconsistency
with the reference counts.
I think something like this would still make sense in a few
cases, although there are no reference counts to check anymore
currently.
-Andi
next prev parent reply other threads:[~2008-02-14 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:31 [2.6 patch] x86: make dump_pagetable() static Adrian Bunk
2008-02-13 22:27 ` Harvey Harrison
2008-02-13 22:36 ` Adrian Bunk
2008-02-14 5:50 ` Ingo Molnar
2008-02-14 7:57 ` Andi Kleen [this message]
2008-02-13 22:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B3F47C.8010803@suse.de \
--to=ak@suse.de \
--cc=bunk@kernel.org \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox